fix: remove produce syntax from spans stream to drastically improve p…

…erformance at 5k + entries
crabnebula-dev · Feb 8, 2024 · e0bedd9 · e0bedd9
1 parent 3eb0abc
commit e0bedd9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/clients/web/src/lib/connection/transport.tsx b/clients/web/src/lib/connection/transport.tsx
@@ -4,7 +4,7 @@ import { InstrumentClient } from "~/lib/proto/instrument.client";
 import { TauriClient } from "~/lib/proto/tauri.client";
 import { SourcesClient } from "~/lib/proto/sources.client.ts";
 import { MetadataClient } from "../proto/meta.client";
-import { SetStoreFunction, createStore, produce } from "solid-js/store";
+import { SetStoreFunction, createStore } from "solid-js/store";
 import {
   HealthCheckRequest,
   HealthCheckResponse_ServingStatus,
@@ -115,11 +115,8 @@ export function addStreamListneners(
 
     const spansUpdate = update.spansUpdate;
     if (spansUpdate && spansUpdate.spanEvents.length > 0) {
-      setMonitorData(
-        "spans",
-        produce((clonedSpans) =>
-          updatedSpans(clonedSpans, spansUpdate.spanEvents)
-        )
+      setMonitorData("spans", (spans) =>
+        updatedSpans(spans, spansUpdate.spanEvents)
       );
     }
   });

diff --git a/clients/web/src/views/dashboard/console.tsx b/clients/web/src/views/dashboard/console.tsx
@@ -69,6 +69,7 @@ export default function Console() {
           placeholder="Filter..."
           class="bg-slate-900 px-1 rounded text-white focus:outline-none focus:border focus:border-slate-400"
         />
+        <div>({filteredLogs().length})</div>
         <LogLevelFilter filter={filter} setFilter={setFilter} />
         <FilterToggle
           defaultPressed