Fix/file path url encoding #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johann-crabnebula
requested review from
atila-crabnebula and
tejas-crabnebula
as code owners
✅ Deploy Preview for cn-devtools-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cn-devtools-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
johann-crabnebula
force-pushed
the
fix/file-path-url-encoding
branch
from
690afbf to
d7b6589
Compare
atila-crabnebula
previously approved these changes
Jan 23, 2024
Co-authored-by: AtilaFassina for CrabNebula <[email protected]>
atila-crabnebula
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the lingering bug from here:
https://linear.app/crabnebula/issue/DT-53/sources-tab-shoud-be-able-to-handle-file-names-containing-
The implementation of escaping
.was not quite right yet. Since there is no proper way to escape them, I simply "invented" the escape code%DDDto replace the dots.(Strictly speaking there is the code
%2Efor.the problem with that one is, that solid router just changes it back to a.and Chrome for example also acts weird with it)Added some URL encoding as well to make sure the rest does not break the URL.
I also noticed that accessing nested files was broken in the previous implementation. As a side effect that is fixed as well.
Furthermore the Unknown View was not properly showing for types that were not in our list at all. A fix for that is included.
Resolves DT-53