fix: property access on undefined exit span #179
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically fixes the error getting thrown on spans that don't have an exit yet.
Even though I have to say that the underlying code is really wonky in the first place (I added the question mark to "restore the original behavior":
The original line looked like this:
If we the span.exits array is empty it will pretty much resolve to something like:
And then it will
Which looks hella ugly and should be revised in the future but does not throw an error.
The updated code:
Knowing that exits can be empty it is easy to spot the previous error. When exits are empty we call the property
.timestamp
on undefined which is not allowed.