Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency @astrojs/solid-js to v4 #203

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 18, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@astrojs/solid-js (source) ^3.0.2 -> ^4.0.0 age adoption passing confidence

Release Notes

withastro/astro (@​astrojs/solid-js)

v4.0.1

Compare Source

Patch Changes

v4.0.0

Compare Source

Major Changes
  • #​6791 37021044dd4382a9b214f89b7c221bf1c93f3e7d Thanks @​patdx! - Render SolidJS components using renderToStringAsync.

    This changes the renderer of SolidJS components from renderToString to renderToStringAsync. It also injects the actual SolidJS hydration script generated by generateHydrationScript, so that Suspense, ErrorBoundary and similar components can be hydrated correctly.

    The server render phase will now wait for Suspense boundaries to resolve instead of always rendering the Suspense fallback.

    If you use the APIs createResource or lazy, their functionalities will now be executed on the server side, not just the client side.

    This increases the flexibility of the SolidJS integration. Server-side components can now safely fetch remote data, call async Astro server functions like getImage() or load other components dynamically. Even server-only components that do not hydrate in the browser will benefit.

    It is very unlikely that a server-only component would have used the Suspense feature until now, so this should not be a breaking change for server-only components.

    This could be a breaking change for components that meet the following conditions:

    • The component uses Suspense APIs like Suspense, lazy or createResource, and
    • The component is mounted using a hydrating directive:
      • client:load
      • client:idle
      • client:visible
      • client:media

    These components will now first try to resolve the Suspense boundaries on the server side instead of the client side.

    If you do not want Suspense boundaries to be resolved on the server (for example, if you are using createResource to do an HTTP fetch that relies on a browser-side cookie), you may consider:

    • changing the template directive to client:only to skip server side rendering completely
    • use APIs like isServer or onMount() to detect server mode and render a server fallback without using Suspense.

v3.0.3

Compare Source

Patch Changes

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Copy link

netlify bot commented Jan 18, 2024

Deploy Preview for cn-devtools-website ready!

Name Link
🔨 Latest commit 68848bf
🔍 Latest deploy log https://app.netlify.com/sites/cn-devtools-website/deploys/65a9787922b34b0007e13e33
😎 Deploy Preview https://deploy-preview-203--cn-devtools-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 70 (🔴 down 28 from production)
Accessibility: 100 (no change from production)
Best Practices: 83 (🔴 down 17 from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 18, 2024

Deploy Preview for cn-devtools-app canceled.

Name Link
🔨 Latest commit 68848bf
🔍 Latest deploy log https://app.netlify.com/sites/cn-devtools-app/deploys/65a97879e4ad220008945821

@CrabNejonas CrabNejonas merged commit 8ffc013 into main Jan 22, 2024
9 checks passed
@CrabNejonas CrabNejonas deleted the renovate/astrojs-solid-js-4.x branch January 22, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant