fix: add the data-spa attribute to the fathom script
#339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cn-devtools-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
atilafassina
approved these changes
Jul 31, 2024
denjell-crabnebula
approved these changes
Jul 31, 2024
atila-crabnebula
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR:
Tracking of SPA navigations might have been not working. Tracking of initial page load was not affected.
When working on integrating Fathom for cloud @beanow-at-crabnebula mentioned that the tracking might be off when using the SPA navigation. After looking at the Fathom docs. It seems like it is best to add the
data-spaattribute for good measure:https://usefathom.com/docs/script/script-advanced#spa