-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Functions support #96
Functions support #96
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
============================================
- Coverage 17.52% 17.16% -0.37%
Complexity 12 12
============================================
Files 38 39 +1
Lines 1837 1882 +45
Branches 160 158 -2
============================================
+ Hits 322 323 +1
- Misses 1480 1525 +45
+ Partials 35 34 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
thanks for your contribution @vytskalt 😊 Will review the PR and check whats wrong with this codecov bot failing the code coverage even when we have about 50%+ code coverage. |
Any ETA? |
@vytskalt will review and merge this PR by end of this week. |
Added support for these commands:
I wasn't able to add FUNCTION LIST and FUNCTION STATS because they respond with RESP3 which isn't supported by Netty (netty/netty#11449). Also FUNCTION DUMP and FUNCTION RESTORE because they use bulk strings to send raw bytes and I wasn't sure how to handle that.
Also, I updated Kotlin to the latest version because I was experiencing some weird issues with compilation and updating fixed it. Detekt didn't work with the new version so I updated it aswell.
EDIT:
INFO modules
returns now more things than just the installed modules so I also accounted for that