Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functions support #96

Merged
merged 9 commits into from
Aug 7, 2023
Merged

Functions support #96

merged 9 commits into from
Aug 7, 2023

Conversation

vytskalt
Copy link
Contributor

@vytskalt vytskalt commented Jun 23, 2023

Added support for these commands:

I wasn't able to add FUNCTION LIST and FUNCTION STATS because they respond with RESP3 which isn't supported by Netty (netty/netty#11449). Also FUNCTION DUMP and FUNCTION RESTORE because they use bulk strings to send raw bytes and I wasn't sure how to handle that.

Also, I updated Kotlin to the latest version because I was experiencing some weird issues with compilation and updating fixed it. Detekt didn't work with the new version so I updated it aswell.

EDIT: INFO modules returns now more things than just the installed modules so I also accounted for that

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.37 ⚠️

Comparison is base (3c38e26) 17.52% compared to head (deb3886) 17.16%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #96      +/-   ##
============================================
- Coverage     17.52%   17.16%   -0.37%     
  Complexity       12       12              
============================================
  Files            38       39       +1     
  Lines          1837     1882      +45     
  Branches        160      158       -2     
============================================
+ Hits            322      323       +1     
- Misses         1480     1525      +45     
+ Partials         35       34       -1     
Flag Coverage Δ
unittests 17.16% <0.00%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...otlin/io/github/crackthecodeabhi/kreds/args/api.kt 7.95% <0.00%> (-0.19%) ⬇️
...rackthecodeabhi/kreds/commands/FunctionCommands.kt 0.00% <0.00%> (ø)
...github/crackthecodeabhi/kreds/connection/Client.kt 30.61% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@crackthecodeabhi
Copy link
Owner

thanks for your contribution @vytskalt 😊

Will review the PR and check whats wrong with this codecov bot failing the code coverage even when we have about 50%+ code coverage.

@vytskalt
Copy link
Contributor Author

thanks for your contribution @vytskalt blush

Will review the PR and check whats wrong with this codecov bot failing the code coverage even when we have about 50%+ code coverage.

Any ETA?

@crackthecodeabhi
Copy link
Owner

@vytskalt will review and merge this PR by end of this week.

@crackthecodeabhi crackthecodeabhi merged commit 014e19d into crackthecodeabhi:main Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants