Merge pull request #14948 from craftcms/bugfix/missing-pg-password

Fix missing `PGPASSWORD` for `db/backup` command
craftcms · May 6, 2024 · 205a9ba · 205a9ba
2 parents 8b1de52 + 979d6ec
commit 205a9ba
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ## Unreleased
 
+- Fixed a bug where the `db/backup` command would prompt for password input on PostgreSQL. ([#14945](https://github.com/craftcms/cms/issues/14945))
 - Fixed a bug where pressing <kbd>Shift</kbd> + <kbd>Spacebar</kbd> wasn’t reliably opening the asset preview modal on the Assets index page. ([#14943](https://github.com/craftcms/cms/issues/14943))
 - Fixed a bug where pressing <kbd>Shift</kbd> + <kbd>Spacebar</kbd> within an asset preview modal wasn’t closing the modal.
 - Fixed a bug where pressing arrow keys within asset preview modals wasn’t retargeting the preview modal to adjacent assets. ([#14943](https://github.com/craftcms/cms/issues/14943))

diff --git a/src/db/pgsql/Schema.php b/src/db/pgsql/Schema.php
@@ -147,7 +147,7 @@ public function getDefaultBackupCommand(?array $ignoreTables = null): string
             $command = $commandFromConfig($command);
         }
 
-        return $command->getExecCommand();
+        return $this->_pgpasswordCommand() . $command->getExecCommand();
     }
 
     /**
-Original file line number
+Diff line change
@@ Expand Up @@
                 $command = $commandFromConfig($command);
             }
-            return $command->getExecCommand();
+            return $this->_pgpasswordCommand() . $command->getExecCommand();
         }
         /**
@@ Expand Down @@