Skip to content

Commit

Permalink
Merge pull request #12581 from craftcms/bugfix/12576-project-config-n…
Browse files Browse the repository at this point in the history
…ame-comments-sync

sync PC name comments from freshly grabbed DB data
  • Loading branch information
brandonkelly authored Feb 3, 2023
2 parents 90fc9da + 6faf8cf commit 41212dd
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
- Fixed a bug where previewing an asset could wipe out all `h1` tags within Redactor fields. ([#12545](https://github.com/craftcms/cms/issues/12545))
- Fixed a bug where `craft\image\Raster::getIsTransparent()` wasn’t working. ([#12565](https://github.com/craftcms/cms/issues/12565))
- Fixed a bug where textual condition rules were still showing a text input when the “is empty” or “has a value” operators were selected. ([#12587](https://github.com/craftcms/cms/pull/12587))
- Fixed a bug where the component name comments in project config YAML files would always lag behind the current project config a little. ([#12576](https://github.com/craftcms/cms/issues/12576), ([#12581](https://github.com/craftcms/cms/pull/12581)))
- Added `craft\helpers\Db::escapeForLike()`.
- `craft\services\Assets::getAllDescendantFolders()` now has a `$withParent` argument, which can be passed `false` to omit the parent folder from the results. ([#12536](https://github.com/craftcms/cms/issues/12536))
- Deprecated `craft\helpers\DateTimeHelper::timeZoneAbbreviation()`.
Expand Down
3 changes: 2 additions & 1 deletion src/services/ProjectConfig.php
Original file line number Diff line number Diff line change
Expand Up @@ -1568,7 +1568,8 @@ protected function updateYamlFiles(): void
'except' => ['.*', '.*/'],
]);

$projectConfigNames = $this->getInternalConfig()->get(self::PATH_META_NAMES);
// get fresh internal config so that all the name comments are properly updated
$projectConfigNames = $this->_loadInternalConfig()->get(self::PATH_META_NAMES);

$uids = [];
$replacements = [];
Expand Down

0 comments on commit 41212dd

Please sign in to comment.