Allow double-clicking anywhere on the table row

Resolves #14379
craftcms · May 14, 2024 · 43fb8d8 · 43fb8d8
1 parent aa4d6db
commit 43fb8d8
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 9 deletions.
diff --git a/CHANGELOG-WIP.md b/CHANGELOG-WIP.md
@@ -2,6 +2,7 @@
 
 ### Content Management
 - It’s now possible to edit assets’ alternative text from the Assets index page. ([#14893](https://github.com/craftcms/cms/discussions/14893))
+- Double-clicking anywhere within a table row on an element index page will now open the element’s editor slideout. ([#14379](https://github.com/craftcms/cms/discussions/14379))
 - Element index checkboxes no longer have a lag when deselected, except within element selection modals. ([#14896](https://github.com/craftcms/cms/issues/14896))
 - Improved mobile styling. ([#14910](https://github.com/craftcms/cms/pull/14910))
 - Improved the look of slideouts.

diff --git a/src/web/assets/cp/dist/cp.js b/src/web/assets/cp/dist/cp.js
diff --git a/src/web/assets/cp/dist/cp.js.map b/src/web/assets/cp/dist/cp.js.map
diff --git a/src/web/assets/cp/src/js/BaseElementIndexView.js b/src/web/assets/cp/src/js/BaseElementIndexView.js
@@ -92,13 +92,9 @@ Craft.BaseElementIndexView = Garnish.Base.extend(
           }
 
           const $target = $(ev.target);
-          var $element;
-
-          if ($target.hasClass('element')) {
-            $element = $target;
-          } else {
-            $element = $target.closest('.element');
-
+          let $element = $target.closest('.element');
+          if (!$element.length) {
+            $element = $target.closest('tr').find('.element:first');
             if (!$element.length) {
               return;
             }