Merge pull request #12726 from craftcms/bugfix/12708-selector-modal-b…

…ottom-padding always update bottom padding on modal fade in
craftcms · Feb 24, 2023 · 5170d71 · 5170d71
2 parents 279a617 + affeba1
commit 5170d71
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,7 @@
 - Fixed a bug where control panel notifications weren’t being announced to screen readers. ([#12714](https://github.com/craftcms/cms/pull/12714))
 - Fixed a bug where localized relations could be moved to a newly-added site rather than copied, when applying project config changes. ([#12702](https://github.com/craftcms/cms/issues/12702))
 - Fixed a bug where element indexes’ “View” buttons could be inconsistently positioned in the toolbar.
+- Fixed a bug where element selector modal footers could hide the modal contents. ([#12708](https://github.com/craftcms/cms/issues/12708))
 
 ## 4.3.10 - 2023-02-17
 

diff --git a/src/web/assets/cp/dist/cp.js b/src/web/assets/cp/dist/cp.js
diff --git a/src/web/assets/cp/dist/cp.js.map b/src/web/assets/cp/dist/cp.js.map
diff --git a/src/web/assets/cp/src/js/BaseElementSelectorModal.js b/src/web/assets/cp/src/js/BaseElementSelectorModal.js
@@ -219,6 +219,10 @@ Craft.BaseElementSelectorModal = Garnish.Modal.extend(
       if (!this.elementIndex) {
         this._createElementIndex();
       } else {
+        // make sure we're able to scroll the entire elementIndex if more elements were added
+        // after modal was first initialised
+        this.updateModalBottomPadding();
+
         // Auto-focus the Search box
         if (!Garnish.isMobileBrowser(true)) {
           this.elementIndex.$search.trigger('focus');