Skip to content

Commit

Permalink
Merge branch 'release/4.2.1.1' into main
Browse files Browse the repository at this point in the history
  • Loading branch information
brandonkelly committed Aug 10, 2022
2 parents 8091f54 + 2ab77ba commit 520908d
Show file tree
Hide file tree
Showing 9 changed files with 33 additions and 28 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Release Notes for Craft CMS 4

## 4.2.1.1 - 2022-08-10

### Fixed
- Fixed a bug where saving an element with invalid field values could result in some field values being forgotten. ([#11756](https://github.com/craftcms/cms/issues/11756))
- Fixed a bug where it wasn’t always possible to serve asset bundles via `webpack-dev-server` over SSL. ([#11758](https://github.com/craftcms/cms/pull/11758))

## 4.2.1 - 2022-08-09

### Added
Expand Down
36 changes: 18 additions & 18 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/config/app.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
return [
'id' => 'CraftCMS',
'name' => 'Craft CMS',
'version' => '4.2.1',
'version' => '4.2.1.1',
'schemaVersion' => '4.0.0.9',
'minVersionRequired' => '3.7.11',
'basePath' => dirname(__DIR__), // Defines the @app alias
Expand Down
3 changes: 1 addition & 2 deletions src/fieldlayoutelements/CustomField.php
Original file line number Diff line number Diff line change
Expand Up @@ -208,8 +208,7 @@ public function formHtml(?ElementInterface $element = null, bool $static = false
$view->setIsDeltaRegistrationActive(
$isDeltaRegistrationActive &&
($element->id ?? false) &&
!$static &&
!$element?->hasErrors(sprintf('%s.*', $this->attribute()))
!$static
);
$html = $view->namespaceInputs(function() use ($element, $static) {
return (string)parent::formHtml($element, $static);
Expand Down
2 changes: 1 addition & 1 deletion src/helpers/Db.php
Original file line number Diff line number Diff line change
Expand Up @@ -767,7 +767,7 @@ public static function parseMoneyParam(
* @param string|bool $value The param value
* @param bool|null $defaultValue How `null` values should be treated
* @return array
* @since 3.4.15
* @since 3.4.14
*/
public static function parseBooleanParam(string $column, mixed $value, ?bool $defaultValue = null): array
{
Expand Down
5 changes: 2 additions & 3 deletions src/services/Webpack.php
Original file line number Diff line number Diff line change
Expand Up @@ -199,11 +199,9 @@ public function getDevServer(string $class): string
* Returns the running status of the webpack dev server.
*
* @param string $class
* @phpstan-param class-string<AssetBundle> $class
* @param string $loopback
* @return bool
* @throws GuzzleException
* @throws ReflectionException
*/
private function _isDevServerRunning(string $class, string $loopback): bool
{
Expand All @@ -216,7 +214,8 @@ private function _isDevServerRunning(string $class, string $loopback): bool
return $this->_isDevServerRunning[$class] = $this->_matchAsset($this->_serverResponse[$loopback], $class);
}

$client = Craft::createGuzzleClient();
// Make sure the request isn't too strict for people running the dev server using https and outside the container
$client = Craft::createGuzzleClient(['verify' => false]);
try {
$res = $client->get(StringHelper::ensureRight($loopback, '/') . 'which-asset');
if ($res->getStatusCode() !== 200) {
Expand Down
2 changes: 1 addition & 1 deletion src/web/assets/cp/dist/cp.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/web/assets/cp/dist/cp.js.map

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion src/web/assets/cp/src/js/ElementEditor.js
Original file line number Diff line number Diff line change
Expand Up @@ -1535,7 +1535,8 @@ Craft.ElementEditor = Garnish.Base.extend(
data,
this.$container.data('delta-names'),
deltaCallback,
this.$container.data('initial-delta-values')
this.$container.data('initial-delta-values'),
this.$container.data('modified-delta-names')
);

// Swap out element IDs with their duplicated ones
Expand Down

0 comments on commit 520908d

Please sign in to comment.