ArrayHelper::ensureNonAssociative()

Implements a better fix for #3947

CHANGELOG-v3.md

@@ -1,5 +1,10 @@
 # Release Notes for Craft CMS 3.x
 
+## Unreleased
+
+### Added
+- Added `craft\helpers\ArrayHelper::ensureNonAssociative()`.
+
 ## 3.1.17 - 2019-03-08
 
 ### Changed

src/fields/Table.php

@@ -12,6 +12,7 @@
 use craft\base\ElementInterface;
 use craft\base\Field;
 use craft\fields\data\ColorData;
+use craft\helpers\ArrayHelper;
 use craft\helpers\DateTimeHelper;
 use craft\helpers\Json;
 use craft\validators\ColorValidator;
@@ -99,6 +100,8 @@ public function init()
 
         if (!is_array($this->defaults)) {
             $this->defaults = [];
+        } else {
+            ArrayHelper::ensureNonAssociative($this->defaults);
         }
 
         // Convert default date cell values to ISO8601 strings
@@ -125,21 +128,6 @@ public function rules()
         return $rules;
     }
 
-    /**
-     * @inheritdoc
-     */
-    public function getSettings(): array
-    {
-        $settings = parent::getSettings();
-
-        // Turn defaults into a non-associative array so it doesn't get reordered when saved to the project config
-        if (!empty($settings['defaults'])) {
-            $settings['defaults'] = array_values($settings['defaults']);
-        }
-
-        return $settings;
-    }
-
     /**
      * @return bool whether minRows was set
      */

src/helpers/ArrayHelper.php

@@ -203,4 +203,16 @@ public static function withoutValue(array $array, $value): array
         static::removeValue($array, $value);
         return $array;
     }
+
+    /**
+     * Ensures an array is non-associative.
+     *
+     * @param array $array
+     */
+    public static function ensureNonAssociative(array &$array)
+    {
+        if (static::isAssociative($array, false)) {
+            $array = array_values($array);
+        }
+    }
 }