Show the "Update all" button even if there are uninstallable updates

Resolves #4230

CHANGELOG-v3.md

@@ -3,6 +3,7 @@
 ## Unreleased
 
 ### Changed
+- The “Update all” button on the Updates utility is now shown even if the page contains some uninstallable updates. ([#4230](https://github.com/craftcms/cms/issues/4230))
 - Craft now stores the Default User Group’s UID in the project config, in case the group’s ID is different across environments.
 - `craft\services\Assets::EVENT_BEFORE_REPLACE_ASSET` event handlers can now change the filename of the replaced asset before it is saved.
 - Improved the performance of background jobs. ([#4219](https://github.com/craftcms/cms/pull/4219))

src/web/assets/updates/dist/UpdatesUtility.js

@@ -7,16 +7,15 @@
             totalAvailableUpdates: 0,
             criticalUpdateAvailable: false,
             allowUpdates: null,
-            showUpdateAllBtn: true,
-            updates: null,
+            installableUpdates: null,
 
             init: function() {
                 this.$body = $('#content');
 
                 var $graphic = $('#graphic'),
                     $status = $('#status');
 
-                this.updates = [];
+                this.installableUpdates = [];
 
                 var data = {
                     forceRefresh: true,
@@ -66,11 +65,11 @@
                                 headingText = Craft.t('app', '{num} Available Updates', {num: this.totalAvailableUpdates});
                             }
 
-                            $('#page-title').find('h1').text(headingText);
+                            $('#header h1').text(headingText);
 
-                            if (this.allowUpdates && this.showUpdateAllBtn && this.updates.length > 1) {
-                                this.createUpdateForm(Craft.t('app', 'Update all'), this.updates)
-                                    .insertAfter($('#header').children('h1'));
+                            if (this.allowUpdates && this.installableUpdates.length > 1) {
+                                this.createUpdateForm(Craft.t('app', 'Update all'), this.installableUpdates)
+                                    .insertAfter($('#header h1 + .flex-grow'));
                             }
                         } else {
                             $graphic.addClass('success');
@@ -87,7 +86,10 @@
 
                 this.totalAvailableUpdates++;
 
-                this.updates.push(new Update(this, updateInfo, isPlugin));
+                var update = new Update(this, updateInfo, isPlugin);
+                if (update.installable) {
+                    this.installableUpdates.push(update);
+                }
             },
 
             createUpdateForm: function(label, updates)
@@ -136,6 +138,7 @@
         {
             updateInfo: null,
             isPlugin: null,
+            installable: true,
 
             $container: null,
             $header: null,
@@ -162,7 +165,7 @@
                     $('<blockquote class="note ineligible"><p>'+this.updateInfo.statusText+'</p></blockquote>').insertBefore(this.$releaseContainer);
 
                     if (this.updateInfo.status === 'expired' || this.updateInfo.latestVersion === null) {
-                        this.updatesPage.showUpdateAllBtn = false;
+                        this.installable = false;
                     }
                 }
             },