Fixed #3849

craftcms · Feb 15, 2019 · a74b553 · a74b553
1 parent c20adf2
commit a74b553
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 15 deletions.
diff --git a/CHANGELOG-v3.md b/CHANGELOG-v3.md
@@ -6,6 +6,7 @@
 - Fixed a bug where the `relatedTo` element query param could include results for elements that were related via soft-deleted Matrix blocks. ([#3846](https://github.com/craftcms/cms/issues/3846))
 - Fixed a bug where some search queries were not returning results when they should, if using MySQL.
 - Fixed an error that could occur when syncing `project.yaml` changes if the `allowAdminChanges` config setting was disabled. ([#3823](https://github.com/craftcms/cms/issues/3823))
+- Fixed an `InvalidConfigException` that was thrown if a user’s photo was soft-deleted. ([#3849](https://github.com/craftcms/cms/issues/3849))
 
 ## 3.1.11 - 2019-02-14
 

diff --git a/src/elements/User.php b/src/elements/User.php
@@ -527,7 +527,7 @@ public static function findIdentityByAccessToken($token, $type = null)
     public $inheritorOnDelete;
 
     /**
-     * @var Asset|null user photo
+     * @var Asset|false|null user photo
      */
     private $_photo;
 
@@ -1191,23 +1191,18 @@ public function setEagerLoadedElements(string $handle, array $elements)
      * Returns the user's photo.
      *
      * @return Asset|null
-     * @throws InvalidConfigException if [[photoId]] is set but invalid
      */
     public function getPhoto()
     {
-        if ($this->_photo !== null) {
-            return $this->_photo;
-        }
-
-        if (!$this->photoId) {
-            return null;
-        }
+        if ($this->_photo === null) {
+            if (!$this->photoId) {
+                return null;
+            }
 
-        if (($this->_photo = Craft::$app->getAssets()->getAssetById($this->photoId)) === null) {
-            throw new InvalidConfigException('Invalid photo ID: ' . $this->photoId);
+            $this->_photo = Craft::$app->getAssets()->getAssetById($this->photoId) ?? false;
         }
 
-        return $this->_photo;
+        return $this->_photo ?: null;
     }
 
     /**
@@ -1218,6 +1213,7 @@ public function getPhoto()
     public function setPhoto(Asset $photo = null)
     {
         $this->_photo = $photo;
+        $this->photoId = $photo->id ?? null;
     }
 
     // Indexes, etc.

diff --git a/src/services/Users.php b/src/services/Users.php
@@ -437,7 +437,7 @@ public function saveUserPhoto(string $fileLocation, User $user, string $filename
         $assetsService = Craft::$app->getAssets();
 
         // If the photo exists, just replace the file.
-        if ($user->photoId) {
+        if ($user->photoId && $user->getPhoto() !== null) {
             // No longer a new file.
             $assetsService->replaceAssetFile($assetsService->getAssetById($user->photoId), $fileLocation, $filenameToUse);
         } else {
@@ -455,7 +455,7 @@ public function saveUserPhoto(string $fileLocation, User $user, string $filename
             $elementsService = Craft::$app->getElements();
             $elementsService->saveElement($photo);
 
-            $user->photoId = $photo->id;
+            $user->setPhoto($photo);
             $elementsService->saveElement($user, false);
         }
     }

diff --git a/src/templates/users/_photo.html b/src/templates/users/_photo.html
@@ -6,7 +6,7 @@
         </div>
             <div class="user-photo-controls">
                 <input type="file" name="photo" class="hidden" />
-                {% if user.photoId %}
+                {% if user.photo %}
                     <div class="btn upload-photo">{{ "Change photo"|t('app') }}</div>
                     <div class="btn delete-photo">{{ "Delete photo"|t('app') }}</div><br /><br />
                     <div class="btn edit-photo" data-photoid="{{ user.photoId }}">{{ "Edit photo"|t('app') }}</div>