Skip to content

Commit

Permalink
Asset thumbs should *not* ignore generateTransformsBeforePageLoad
Browse files Browse the repository at this point in the history
Fixes #12750
  • Loading branch information
brandonkelly committed Mar 3, 2023
1 parent aad45b7 commit ab1ad5a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
- Fixed a bug where localized relations could be moved to a newly-added site rather than copied, when applying project config changes. ([#12702](https://github.com/craftcms/cms/issues/12702))
- Fixed a bug where element indexes’ “View” buttons could be inconsistently positioned in the toolbar.
- Fixed a bug where element selector modal footers could hide the modal contents. ([#12708](https://github.com/craftcms/cms/issues/12708))
- Fixed a bug where asset thumbnails weren’t respecting the `generateTransformsBeforePageLoad` config setting. ([#12750](https://github.com/craftcms/cms/issues/12750))

## 4.3.10 - 2023-02-17

Expand Down
2 changes: 1 addition & 1 deletion src/services/Assets.php
Original file line number Diff line number Diff line change
Expand Up @@ -643,7 +643,7 @@ public function getThumbUrl(Asset $asset, int $width, ?int $height = null): stri
'mode' => 'crop',
]);

$url = $asset->getUrl($transform, false);
$url = $asset->getUrl($transform);

if ($url === null) {
return AssetsHelper::iconUrl($extension);
Expand Down

0 comments on commit ab1ad5a

Please sign in to comment.