Merge pull request #14902 from craftcms/bugfix/admin-table-delete-foo…

…ter-action-on-non-endpoint-data Fixed footer delete action for non endpoint admin tables
craftcms · Apr 30, 2024 · ad7be43 · ad7be43
2 parents 9d6fda2 + 5020686
commit ad7be43
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -37,6 +37,7 @@
 - Fixed a bug where `craft\elements\db\ElementQuery::count()` could return the wrong number if the query had a cached result, with `offset` or `limit` params.
 - Console requests no longer filter out info logs. ([#14280](https://github.com/craftcms/cms/issues/14280), [#14434](https://github.com/craftcms/cms/pull/14434))
 - Fixed a styling issue with Categories and Entries fields when “Maintain Hierarchy” was enabled.
+- Fixed a bug where Delete actions weren’t working in admin tables. ([craftcms/commerce#3444](https://github.com/craftcms/commerce/issues/3444))
 
 ## 4.8.11 - 2024-04-29
 

diff --git a/packages/craftcms-vue/admintable/App.vue b/packages/craftcms-vue/admintable/App.vue
@@ -816,7 +816,7 @@
             label: Craft.t('app', 'Delete'),
             action: this.deleteAction,
             error: true,
-            ajax: true,
+            ajax: this.tableDataEndpoint ? true : false,
             allowMultiple: this.allowMultipleDeletions,
             separator: itemActions.length ? true : false,
           });

diff --git a/src/web/assets/admintable/dist/css/app.css b/src/web/assets/admintable/dist/css/app.css
diff --git a/src/web/assets/admintable/dist/css/app.css.map b/src/web/assets/admintable/dist/css/app.css.map
diff --git a/src/web/assets/admintable/dist/js/app.js b/src/web/assets/admintable/dist/js/app.js
diff --git a/src/web/assets/admintable/dist/js/app.js.map b/src/web/assets/admintable/dist/js/app.js.map
diff --git a/src/web/assets/admintable/dist/manifest.json b/src/web/assets/admintable/dist/manifest.json
@@ -1 +1 @@
-{"app.css":"/css/app.css","app.js":"/js/app.js","app.js.map":"/js/app.js.map"}
+{"app.css":"/css/app.css","app.js":"/js/app.js","app.css.map":"/css/app.css.map","app.js.map":"/js/app.js.map"}
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		{"app.css":"/css/app.css","app.js":"/js/app.js","app.js.map":"/js/app.js.map"}
		{"app.css":"/css/app.css","app.js":"/js/app.js","app.css.map":"/css/app.css.map","app.js.map":"/js/app.js.map"}