Skip to content

Commit

Permalink
Update notifications twig and container for status role
Browse files Browse the repository at this point in the history
Resolves #12714
  • Loading branch information
gcamacho079 authored and brandonkelly committed Feb 22, 2023
1 parent df58763 commit b5e310e
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion src/templates/_layouts/components/notifications.twig
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div id="notifications" aria-labelledby="cp-notification-heading" role="region">
<div id="notifications" role="status">
<h2 id="cp-notification-heading" class="visually-hidden">{{ 'Notifications'|t('app') }}</h2>
</div>

Expand Down
2 changes: 1 addition & 1 deletion src/web/assets/cp/dist/cp.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/web/assets/cp/dist/cp.js.map

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions src/web/assets/cp/src/js/CP.js
Original file line number Diff line number Diff line change
Expand Up @@ -1467,9 +1467,9 @@ Craft.CP.Notification = Garnish.Base.extend({
'data-type': this.type,
}).appendTo(Craft.cp.$notificationContainer);

const $body = $('<div class="notification-body"/>')
.appendTo(this.$container)
.attr('role', 'status');
const $body = $('<div class="notification-body"/>').appendTo(
this.$container
);

if (this.settings.icon) {
const $icon = $('<span/>', {
Expand Down

0 comments on commit b5e310e

Please sign in to comment.