Update existing transforms' configs

craftcms · Feb 4, 2023 · d81e156 · d81e156
1 parent 855a18c
commit d81e156
Showing 1 changed file with 19 additions and 10 deletions.
diff --git a/src/migrations/m221027_160703_add_image_transform_fill.php b/src/migrations/m221027_160703_add_image_transform_fill.php
@@ -5,6 +5,7 @@
 use Craft;
 use craft\db\Migration;
 use craft\db\Table;
+use craft\services\ProjectConfig;
 
 /**
  * m221027_160703_add_image_transform_fill migration.
@@ -18,29 +19,37 @@ public function safeUp(): bool
     {
         // Place migration code here...
         $this->addColumn(Table::IMAGETRANSFORMS, 'fill', $this->string(11)->null()->after('interlace'));
-        $allowUpscale = Craft::$app->getConfig()->getGeneral()->upscaleImages;
-        $this->addColumn(Table::IMAGETRANSFORMS, 'upscale', $this->boolean()->notNull()->defaultValue($allowUpscale)->after('fill'));
+        $this->addColumn(Table::IMAGETRANSFORMS, 'upscale', $this->boolean()->notNull()->defaultValue(true)->after('fill'));
 
-        $values = ['stretch', 'fit', 'crop', 'letterbox'];
+        $modeOptions = ['stretch', 'fit', 'crop', 'letterbox'];
         if ($this->db->getIsPgsql()) {
             // Manually construct the SQL for Postgres
             $check = '[[mode]] in (';
-            foreach ($values as $i => $value) {
-                if ($i != 0) {
+            foreach ($modeOptions as $i => $value) {
+                if ($i !== 0) {
                     $check .= ',';
                 }
                 $check .= $this->db->quoteValue($value);
             }
             $check .= ')';
             $this->execute("alter table {{%imagetransforms}} drop constraint {{%imagetransforms_mode_check}}, add check ({$check})");
         } else {
-            $this->alterColumn(
-                Table::IMAGETRANSFORMS,
-                'mode',
-                $this->enum('mode', ['stretch', 'fit', 'crop', 'letterbox'])->notNull()->defaultValue('crop'),
-            );
+            $this->alterColumn(Table::IMAGETRANSFORMS, 'mode', $this->enum('mode', $modeOptions)->notNull()->defaultValue('crop'));
         }
 
+        $projectConfig = Craft::$app->getProjectConfig();
+        $schemaVersion = $projectConfig->get('system.schemaVersion', true);
+
+        if (version_compare($schemaVersion, '4.4.0.3', '<')) {
+            // Hard-code the existing transforms with the current upscaleImages config value
+            $generalConfig = Craft::$app->getConfig()->getGeneral();
+            $transforms = $projectConfig->get(ProjectConfig::PATH_IMAGE_TRANSFORMS) ?? [];
+            foreach ($transforms as $uid => $config) {
+                $config['upscale'] = $generalConfig->upscaleImages;
+                $path = sprintf('%s.%s', ProjectConfig::PATH_IMAGE_TRANSFORMS, $uid);
+                $projectConfig->set($path, $config);
+            }
+        }
 
         return true;
     }