Fixed #4939

craftcms · Sep 13, 2019 · e6cd1b1 · e6cd1b1
1 parent 2a1e5dc
commit e6cd1b1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/CHANGELOG-v3.md b/CHANGELOG-v3.md
@@ -5,6 +5,7 @@
 ### Fixed
 - Fixed a bug where asset queries’ `withTransforms` param wasn’t working for eager-loaded assets. ([#4931](https://github.com/craftcms/cms/issues/4931))
 - Fixed a bug where the "Edit Image" element action sometimes would be missing. ([#3349](https://github.com/craftcms/cms/issues/3349))
+- Fixed a bug where querying for elements by their Lightswitch field value could only return elements that had been saved since the Lightswitch field was added. ([#4939](https://github.com/craftcms/cms/issues/4939))
 
 ## 3.3.3 - 2019-09-12
 

diff --git a/src/fields/Lightswitch.php b/src/fields/Lightswitch.php
@@ -12,6 +12,7 @@
 use craft\base\Field;
 use craft\base\PreviewableFieldInterface;
 use craft\base\SortableFieldInterface;
+use craft\elements\db\ElementQueryInterface;
 use GraphQL\Type\Definition\Type;
 use yii\db\Schema;
 
@@ -118,6 +119,14 @@ public function normalizeValue($value, ElementInterface $element = null)
         return (bool)$value;
     }
 
+    /**
+     * @inheritdoc
+     */
+    public function modifyElementsQuery(ElementQueryInterface $query, $value)
+    {
+        return parent::modifyElementsQuery($query, $value ? ':notempty:' : ':empty:');
+    }
+
     /**
      * @inheritdoc
      */