Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft and entry not propagated correctly in certain conditions #10634

Closed
vnali opened this issue Feb 23, 2022 · 7 comments
Closed

draft and entry not propagated correctly in certain conditions #10634

vnali opened this issue Feb 23, 2022 · 7 comments
Labels

Comments

@vnali
Copy link
Contributor

vnali commented Feb 23, 2022

yesterday some issues mentioned on discord.
there are some paths to reproduce those:

Entry not found error

  1. create a section with propagate to all sites method for site 1
  2. click +new entry, add title, leave editing entry or even click save draft
  3. add another enabled site -site2- for that section
  4. click to edit that entry and go to site 2.
    it throws entry not found error

entry -current state- not propagated

  1. create a section with propagate to all sites method for site 1
  2. click +new entry, add title, create entry
  3. edit that entry, change the title, then leave the entry
  4. add another enabled site -site2- for that section
  5. click to edit that entry for site1, you can't see enabled status for site2 on site status on right side
  6. click to edit that entry for site2, you can see enabled status for both site

only draft for an entry not propagated

  1. create a section with propagate to all sites method for site 1
  2. click +new entry, add title, create entry
  3. edit that entry, change the title, click create draft
  4. add another enabled site -site2- for that section
  5. you can see current status is propagated correctly
  6. you can see that draft is not propagated for site2

also with changing path to create entry (applying draft/creating draft/leaving without saving and ...), we can see similar behaviors for drafts, revisions and ...

Additional info

  • Craft version: 3.7.33
@vnali vnali added the bug label Feb 23, 2022
@timkelty
Copy link
Contributor

@vnali Thanks for reporting!
Fixed for the next release: 681b342

@vnali
Copy link
Contributor Author

vnali commented Feb 25, 2022

@timkelty thanks. i applied and tested this fix -actually deleted redundant lines deleted by Brandon- on local and it works for all 3 mentioned scenarios but if i go further i can't see revisions propagated too:

  1. create a section with propagate to all sites method for site 1
  2. click +new entry, add title, create entry
  3. edit that entry, change the title, click create draft and apply draft, then change title -with or without clicking create draft-
  4. add another enabled site -site2- for that section
  5. you can see current status and drafts are propagated correctly
  6. you can see the revisions are not propagated for site2

@timkelty
Copy link
Contributor

@vnali Revision are addressed in Craft 4, but is a breaking change.

For the next Craft 3 release, we've added a --revisions flag to the resave/entries cli command, so following your section changes, you can run:

craft resave/entries --section=my-section --revisions

@vnali
Copy link
Contributor Author

vnali commented Feb 25, 2022

@timkelty after applying new changes to resave controller, it throws 'Skipped resaving .... because it's a revision' which it is related to third argument here explicitly set to true.

@timkelty
Copy link
Contributor

timkelty commented Feb 25, 2022

@vnali d'oh…try now :)

brandonkelly added a commit that referenced this issue Feb 25, 2022
@vnali
Copy link
Contributor Author

vnali commented Feb 26, 2022

It works. thanks!

@timkelty
Copy link
Contributor

@vnali thanks for the thorough report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants