-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.5]: Notification gets stuck on entry edit page and prevents further entry save via shortcut #13591
Comments
Also experiencing this after we upgraded this morning. In addition we are also experiencing the status button is always toggled to ENABLED, even when the entry is disabled. And, conditional fields aren't toggling anymore. Javascript issue? |
Yup, I also just verified the status button issue. I did a quick test with a conditional and it worked for me though. |
Opened an issue for the status button #13595 |
I just found this comment by @brandonkelly in a related issue. So it seems that the second part of the issue (blocked shortcuts) is kind of intended behaviour. I would argue though that shortcuts should not be blocked when the focus is not on the notification, eg. when the user continues editing the entry. It's not unusual for an author to make a change, save, realise that he wants another change, do that, and save again. Right now he is presented with a 'save web page' screen. I predict this will be frustrating for many. At least I stumbled upon it almost immediately. |
Also running into this immediately after upgrading to 4.5. Extremely frustrating behaviour. |
Craft 4.5.1 is out now with a fix for this. Now UI layers can be configured to allow shortcuts to bubble up to their parent layers, and we’re taking advantage of that for CP notifications. So they can add their Esc shortcut without interfering with previously-registered ones. |
@brandonkelly Thanks for fixing the blocked shortcut issue on such a short notice! The first part though remains as described above (the notification gets stuck if the user clicks outside of it). |
Sorry, overlooked that. Fixed now for the next release. |
Craft 4.5.2 is out with a fix for the |
What happened?
Description
When editing an entry and hitting
save and continue editing
the notification is not automatically discarded if the user continues editing the entry (thus taking the focus away from the notification).A further complication, which is also new to 4.5:
While the notification is open, the shortcut for
save and continue editing
becomes inactive and insteadctrl+s
triggers the native browser functionality of trying to save the web page. That's a big gotcha, because, due to the first issue, the notification is very likely to have stayed open without the author noticing.Steps to reproduce
Expected behavior
A notification appears and is discarded after the amount of time set in the user preferences.
Actual behavior
The notification is only automatically discarded if you don't click anywhere before it disappears.
Craft CMS version
4.5
PHP version
No response
Operating system and version
No response
Database type and version
No response
Image driver and version
No response
Installed plugins and versions
The text was updated successfully, but these errors were encountered: