Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x]: Entries with showStatusField: false can be disabled in bulk operations #13854

Closed
realjoshharrison opened this issue Oct 19, 2023 · 3 comments
Assignees

Comments

@realjoshharrison
Copy link

What happened?

Description

I have a Single with showStatusField set to false, which operates as my site globals. It cannot be disabled from the Entries screen when only this entry is selected, as the button is disabled as expected:

Screenshot 2023-10-19 at 14 37 46

However, if I select another entry which has an enabled status field, the button becomes available and I can disable my site globals as part of the bulk operation:

Screenshot 2023-10-19 at 14 37 53

Screenshot 2023-10-19 at 14 39 05

Steps to reproduce

  1. Add two sections: one with it's entry type status field hidden, and another with the status field visible.
  2. Create two entries from these and select them both in the Entries admin screen, then disable them both.

Expected behavior

The entry with showStatusField: false is unaffected by the bulk operation. Any others are processed as normal.

Actual behavior

All selected entries are disabled indiscriminately.

Craft CMS version

4.5.6.1

PHP version

8.2.0

Operating system and version

MAMP Pro 6.8.1, Darwin 22.6.0, MacOS 13.5.2

Database type and version

MySQL 5.7.39

Image driver and version

Imagick 3.7.0 (ImageMagick 6.9.6-2)

Installed plugins and versions

  • CKEditor 3.6.0
  • CP Field Inspect 1.4.4
@i-just
Copy link
Contributor

i-just commented Oct 20, 2023

Hi, thanks for reporting! I raised a PR for this.

@brandonkelly
Copy link
Member

Craft 4.5.9 is out with a fix for this. Thanks again!

@datpaitoon17
Copy link

What happened?

Description

I have a Single with showStatusField set to false, which operates as my site globals. It cannot be disabled from the Entries screen when only this entry is selected, as the button is disabled as expected:

Screenshot 2023-10-19 at 14 37 46

However, if I select another entry which has an enabled status field, the button becomes available and I can disable my site globals as part of the bulk operation:

Screenshot 2023-10-19 at 14 37 53

Screenshot 2023-10-19 at 14 39 05

Steps to reproduce

  1. Add two sections: one with it's entry type status field hidden, and another with the status field visible.
  2. Create two entries from these and select them both in the Entries admin screen, then disable them both.

Expected behavior

The entry with showStatusField: false is unaffected by the bulk operation. Any others are processed as normal.

Actual behavior

All selected entries are disabled indiscriminately.

Craft CMS version

4.5.6.1

PHP version

8.2.0

Operating system and version

MAMP Pro 6.8.1, Darwin 22.6.0, MacOS 13.5.2

Database type and version

MySQL 5.7.39

Image driver and version

Imagick 3.7.0 (ImageMagick 6.9.6-2)

Installed plugins and versions

  • CKEditor 3.6.0
  • CP Field Inspect 1.4.4

@241331f3528e4a53c61b6e8a7b69af18789707ed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants