Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/13854 set status bulk action #13856

Closed
wants to merge 4 commits into from

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Oct 20, 2023

Description

Don’t change the element’s status via bulk action if its type’s showStatusField is false.

Related issues

#13854

@i-just i-just requested a review from brandonkelly October 20, 2023 08:32
@brandonkelly
Copy link
Member

This would be a breaking change for any element types that are overriding showStatusField() and keeping its visibility set to protected. So we should make this a 5.0 change instead.

@brandonkelly
Copy link
Member

Just remembered this is already supposed to be handled via the SetStatus action trigger, but there was a JS bug where only the first selected element was being respected.

@brandonkelly brandonkelly deleted the bugfix/13854-set-status-bulk-action branch October 23, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants