Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element Sources registry #1629

Closed
brandonkelly opened this issue Apr 13, 2017 · 2 comments
Closed

Element Sources registry #1629

brandonkelly opened this issue Apr 13, 2017 · 2 comments
Assignees
Labels
enhancement improvements to existing features extensibility 🔌 features related to plugin/module dev

Comments

@brandonkelly
Copy link
Member

brandonkelly commented Apr 13, 2017

If you have an asset volume with a ton of subfolders on the same level, JS has to initialize them all at once when they are first made visible on the Assets index page, which can take a while.

To fix this, there should be an Element Sources Registry, which contains a full record of all element types’ sources, and which could be loaded in stages. So when expanding an asset volume, for example, its subfolders could be lazy loaded in batches of 50 or 100.

This would probably manifest as an ElementSources service with a few methods that element types could use to keep their source lists updated. Behind the scenes, the sources would be stored in an elementsources DB table. Element types’ getSources() functions would go away.

@brandonkelly brandonkelly self-assigned this Apr 13, 2017
@brandonkelly brandonkelly added the enhancement improvements to existing features label Apr 13, 2017
@sjelfull
Copy link
Contributor

sjelfull commented Sep 4, 2017

Some UX feedback on this:
It should be very quick to jump to anywhere in the source list.

As an example: Say i'm looking for a folder named "Images from Summer School". I don't want to scroll down 50 or 100 at a time, wait for the loading to finish, scroll some more, until I get to the folder.

Likewise, it should be possible to get back to a position in a element source. In this case, that can be a query parameter + a A-Z jump nav. Related to #1596 and #818

@leevigraham
Copy link
Contributor

Adding the UX feedback… ordering numbered folders should use numeric, not text ordering:

image

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
enhancement improvements to existing features extensibility 🔌 features related to plugin/module dev
Projects
None yet
Development

No branches or pull requests

3 participants