Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Degraded performance in CP Assets view for folders with many subfolders #5809

Closed
monachilada opened this issue Mar 18, 2020 · 4 comments
Closed
Labels
bug severity:normal Bugs that affect typical usage

Comments

@monachilada
Copy link
Contributor

monachilada commented Mar 18, 2020

Description

The performance of the assets page in the CP when it is asked to open a folder with a lot of subfolders in it is resulting page crashes in Chrome, Firefox and Safari on a recent MacBook Pro. Estimate is about 15k sub folders in the Assets volume that can be seen in the screenshots below.

If the folder has never been opened in the particular browser of choice the page will load ok, but as soon as the attempt to expand the folder is made, this will result in the freeze. Subsequent page loads will then also freeze, as the browser appears to attempt to remember the user preference and have that folder opened, making the assets page essentially unusable 😫.

Chrome
Firefox

Steps to reproduce

  1. Have a lot of sub folders in a volume or folder
  2. Attempt to expand the folder to show its contents

Additional info

  • Craft version: 3.4.10.1 (Pro)
  • PHP version: 7.3.11
  • OS version: Linux 4.19.0-0.bpo.6-amd64
  • Database driver & version: MySQL 5.5.5
  • Image driver & version: Imagick 3.4.3 (ImageMagick 7.0.8-58)
  • Plugins & versions:
    • Control Panel Nav 3.0.8.1
    • CP Field Inspect 1.1.3
    • CraftQL dev-master
    • Do It Yourself widget 2.0.1
    • Embedded Assets 2.2.1
    • Entry Instructions 1.0.7
    • Feed Me 4.2.1.1
    • Mailjet 1.2.0
    • MatrixMate 1.2.5
    • Preparse Field v1.1.0
    • Queue Manager 1.2.0
    • Redactor 2.6.1
    • Relabel 1.3.4
    • SEO 3.2.48
    • Servd Assets and Helpers 1.2.8
    • Tags 1.0.6
    • Typed link field 2.0.0-beta.7
    • Webhooks 2.2.0
@monachilada
Copy link
Contributor Author

Also affects modal asset windows triggered from asset fields, making them also unusable.

@brandonkelly
Copy link
Member

This is a known issue. We’re considering a couple ways to solve it, such as #1629. I’ll leave this open and update it once we have a solution.

@brandonkelly brandonkelly added bug severity:normal Bugs that affect typical usage labels Mar 19, 2020
@brandonkelly brandonkelly added this to the 4.0 milestone Mar 19, 2020
@brandonkelly brandonkelly removed this from the 5.0 milestone Jun 3, 2022
@brandonkelly
Copy link
Member

This will be resolved in Craft 3.8 and 4.4, thanks to a bit of an asset index redesign that moves subfolders into the element listing, and paginates them alongside your assets. (See the Rethinking Volume Subfolders blog post and PR #12558 for more info.)

@brandonkelly
Copy link
Member

Craft 3.8 and 4.4 are both out now, with the aforementioned volume folder navigation improvements 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug severity:normal Bugs that affect typical usage
Projects
None yet
Development

No branches or pull requests

2 participants