Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation isn't performed when enabling entries from entry index page. #2

Closed
angrybrad opened this issue Jan 27, 2017 · 1 comment
Closed

Validation isn't performed when enabling entries from entry index page. #2

angrybrad opened this issue Jan 27, 2017 · 1 comment
Labels
bug severity:normal Bugs that affect typical usage

Comments

@angrybrad
Copy link
Member

Environment:

  • Craft version: 3.x
  • PHP version: 7.x
  • Database driver & version: MySQL & PostgreSQL
  • Plugins & versions:

Description:

When enabling an entry from the bulk action dropdown on the edit entry page, entry validation doesn't run, making it possible for enabled entries to go live with required fields that have no data in them.

Steps to reproduce:

Go to entry index page. Enable entries that have required fields and no data in them.
@angrybrad angrybrad added bug severity:normal Bugs that affect typical usage labels Jan 27, 2017
@angrybrad
Copy link
Member Author

Possible solution would be to save an additional "isValid" column when saving the entry that is checked.

@johanneslamers johanneslamers mentioned this issue Feb 1, 2017
Closed
@my2ter my2ter mentioned this issue Feb 1, 2017
Closed
brandonkelly added a commit that referenced this issue Feb 3, 2017
@brandonkelly
Set Status action updates
54e6f32 
Resolves #2
@narration-sd narration-sd mentioned this issue Feb 7, 2017
Closed
@alambc alambc mentioned this issue Feb 22, 2017
Closed
@narration-sd narration-sd mentioned this issue Mar 30, 2017
Closed
@damienbuckley damienbuckley mentioned this issue May 15, 2017
Closed
leevigraham referenced this issue in leevigraham/cms Jun 1, 2017
@leevigraham
Use entry model to get ID rather than variable
2ad1e23 
This fixes an issue where changing the entryType of an existing entry triggers a 500 error:

PHP Notice 'yii\base\ErrorException' with message 'Undefined index: entryId' 

in /Volumes/Sites/Personal/craft3/vendor/craftcms/cms/src/controllers/EntriesController.php:773

Stack trace:
#0 … vendor/yiisoft/yii2/base/InlineAction.php(57): craft\controllers\EntriesController->actionSwitchEntryType()
#1 … vendor/yiisoft/yii2/base/InlineAction.php(57): ::call_user_func_array:{/Volumes/Sites/Personal/craft3/vendor/yiisoft/yii2/base/InlineAction.php:57}('???', '???')
#2 … vendor/yiisoft/yii2/base/Controller.php(156): yii\base\InlineAction->runWithParams('???')
craftcms#3 … vendor/yiisoft/yii2/base/Module.php(523): yii\base\Controller->runAction('???', '???')
craftcms#4 … vendor/craftcms/cms/src/web/Application.php(246): yii\base\Module->runAction('???', '???')
craftcms#5 … vendor/craftcms/cms/src/web/Application.php(385): craft\web\Application->runAction('???', '???')
craftcms#6 … vendor/craftcms/cms/src/web/Application.php(206): craft\web\Application->_processActionRequest('???')
craftcms#7 … vendor/yiisoft/yii2/base/Application.php(380): craft\web\Application->handleRequest('???')
craftcms#8 … web/index.php(33): yii\base\Application->run()
craftcms#9 {main}
brandonkelly pushed a commit that referenced this issue Jun 1, 2017
@leevigraham @brandonkelly
Use entry model to get ID rather than variable
53c6d6c 
This fixes an issue where changing the entryType of an existing entry triggers a 500 error:

PHP Notice 'yii\base\ErrorException' with message 'Undefined index: entryId' 

in /Volumes/Sites/Personal/craft3/vendor/craftcms/cms/src/controllers/EntriesController.php:773

Stack trace:
#0 … vendor/yiisoft/yii2/base/InlineAction.php(57): craft\controllers\EntriesController->actionSwitchEntryType()
#1 … vendor/yiisoft/yii2/base/InlineAction.php(57): ::call_user_func_array:{/Volumes/Sites/Personal/craft3/vendor/yiisoft/yii2/base/InlineAction.php:57}('???', '???')
#2 … vendor/yiisoft/yii2/base/Controller.php(156): yii\base\InlineAction->runWithParams('???')
#3 … vendor/yiisoft/yii2/base/Module.php(523): yii\base\Controller->runAction('???', '???')
#4 … vendor/craftcms/cms/src/web/Application.php(246): yii\base\Module->runAction('???', '???')
#5 … vendor/craftcms/cms/src/web/Application.php(385): craft\web\Application->runAction('???', '???')
#6 … vendor/craftcms/cms/src/web/Application.php(206): craft\web\Application->_processActionRequest('???')
#7 … vendor/yiisoft/yii2/base/Application.php(380): craft\web\Application->handleRequest('???')
#8 … web/index.php(33): yii\base\Application->run()
#9 {main}
@andrelopez andrelopez mentioned this issue Jul 7, 2017
Closed
@andrelopez andrelopez mentioned this issue Aug 30, 2017
Closed
angrybrad pushed a commit that referenced this issue Oct 19, 2017
@ebeauchamps
Merge pull request #2 from craftcms/develop
c9d4519 
Merging from upstream
@retop retop mentioned this issue Nov 24, 2017
Closed
@E2design E2design mentioned this issue Dec 8, 2017
Open
@aashish-pixere aashish-pixere mentioned this issue Dec 28, 2017
Closed
@ddbr ddbr mentioned this issue Jan 25, 2018
Closed
@jonlivingston jonlivingston mentioned this issue Jan 26, 2018
Closed
@steveooo9 steveooo9 mentioned this issue Jan 30, 2018
Closed
@Rainbowlemon Rainbowlemon mentioned this issue Feb 14, 2018
Closed
@leigeber leigeber mentioned this issue Feb 21, 2018
Closed
@kr37 kr37 mentioned this issue Mar 20, 2018
Closed
@brandonkelly brandonkelly mentioned this issue Mar 21, 2018
Closed
@ghost ghost mentioned this issue Apr 19, 2018
Open
@narration-sd narration-sd mentioned this issue Apr 25, 2018
Open
@ul8 ul8 mentioned this issue Jun 20, 2018
Closed
@alexanderloewe alexanderloewe mentioned this issue Dec 4, 2022
Closed
@bob-pixeldeluxe bob-pixeldeluxe mentioned this issue Dec 7, 2022
Closed
@FabioIaderosa FabioIaderosa mentioned this issue Dec 9, 2022
Closed
@andersaloof andersaloof mentioned this issue Dec 14, 2022
Closed
@iwfweb iwfweb mentioned this issue Feb 16, 2023
Closed
@wbdzynr wbdzynr mentioned this issue Mar 30, 2023
Closed
@joepagan joepagan mentioned this issue Jun 8, 2023
Closed
@leowebguy leowebguy mentioned this issue Aug 25, 2023
Closed
@zzseba78 zzseba78 mentioned this issue Aug 25, 2023
Closed
@moldedjelly moldedjelly mentioned this issue Sep 19, 2023
Closed
@bowen31337 bowen31337 mentioned this issue Oct 5, 2023
Open
@robinbeatty robinbeatty mentioned this issue Oct 31, 2023
Closed
This was referenced Dec 19, 2023
Closed
Closed
@DTesch-Level-R DTesch-Level-R mentioned this issue Jan 9, 2024
Closed
@hhentschel hhentschel mentioned this issue Feb 15, 2024
Closed
@LinneaHarts LinneaHarts mentioned this issue Apr 26, 2024
Closed
@loqus loqus mentioned this issue Jun 14, 2024
Closed
@MoritzLost MoritzLost mentioned this issue Jul 24, 2024
Closed
@chadcrowell chadcrowell mentioned this issue Aug 6, 2024
Closed
@funkysoul funkysoul mentioned this issue Aug 6, 2024
Closed
@pnpaes pnpaes mentioned this issue Aug 23, 2024
Closed
@hatyi hatyi mentioned this issue Sep 12, 2024
Closed
@stephenmatthews stephenmatthews mentioned this issue Oct 24, 2024
Open
@joshmcoffman joshmcoffman mentioned this issue Oct 31, 2024
Open
@FabioIaderosa FabioIaderosa mentioned this issue Nov 1, 2024
Closed
@fancy-pug fancy-pug mentioned this issue Nov 13, 2024
Closed
@tibbis tibbis mentioned this issue Nov 13, 2024
Closed
@peter0503 peter0503 mentioned this issue Dec 12, 2024
Closed
@peter0503 peter0503 mentioned this issue Jan 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug severity:normal Bugs that affect typical usage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brandonkelly @angrybrad