-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: make 'login as user' a permission (per user group) #3501
Comments
An “Impersonate users” permission has just been added for the next 3.2 Beta release. It doesn’t take user groups into account, however even if a user has that permission, a “Login as user” option will only show up for users with equal or fewer permissions assigned to them, so there’s no possibility of user impersonation being used as a permission escalation vector. |
Hi @brandonkelly, I was going to create a new issue but this seems related? Description
Additional info
|
@moreguppy if the artist has any permissions that the editor doesn’t have (either directly or via the user group), then impersonation wan’t be allowed. If you’re sure that’s the case, please send in your |
@brandonkelly thanks for the help, that worked. Perhaps under 'Impersonate Users' checkbox, there could be sub-checkboxes to pick which user groups they can impersonate? |
@moreguppy Part of the reason we didn’t give user group-specific permissions is, there’s still the possibility that a user has some permissions set directly on their account, so even if they are in the permitted user group, you may want them to be excluded from impersonation. Which would just add another layer of confusion like you had earlier. (“User A has permission to ‘Impersonate users’ and ‘Impersonate users in the Artists group’, and yet they still can’t impersonate my Artist user - WTF!”) I think the pure permission-based approach should be fine. If you feel comfortable having User A impersonate User B, then you should also feel comfortable ensuring they have at least all the same permissions as User B in the first place. |
Description
I would like one of my editors to be able to login as another user, but I do not want to make him an admin. Seems like this is now impossible. Would be great if you could set a permission for this, would be even better if this could be done per user group.
The text was updated successfully, but these errors were encountered: