Use buildId to determine caching headers for a load-balanced/rolling deployment
#10705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timkelty
changed the title
resourceHash to determine caching headers on a rolling deploymentbuildId to determine caching headers for a load-balanced/rolling deployment
# Conflicts: # src/web/AssetManager.php
|
Craft 4.0.0-beta.4 is out now with this change. |
|
Already in the 4.x docs, and just added a tip here: https://craftcms.com/knowledge-base/configuring-load-balanced-environments#cpresources-folder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows us to send CP resources with cache headers, by introducing a new config setting
GeneralConfig::$buildId.When set, CP resource URLs will be generated with a
buildId=xxxquery param.Only if the
buildIdfrom the request matches the config setting, orGeneralConfig::$buildIdis left asnull, will we serve cache headers.A load-balanced environment should set
GeneralConfig::$buildIdto something unique to the deployment, such as aGIT_SHAenv, or a deployment timestamp.Related issues