-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change TypeConditionRule
to allow multiple selections of entry types
#11124
Change TypeConditionRule
to allow multiple selections of entry types
#11124
Conversation
There’s no way we can know all of the places an entry condition may be used, so rather than trying to update existing configs with a migration, the condition rule should just be able to handle an outdated configuration, e.g. by normalizing the config array from the constructor. |
@brandonkelly have done the following:
I also merged |
# Conflicts: # CHANGELOG-WIP.md
If you move the config normalization to the constructor, you should be able to remove the deprecated properties entirely, right? |
If we remove those and someone was accessing those directly you would get an error? I was trying to be overly cautious and make sure it wasn't a breaking change. Granted I probably still could have done it in the constructor which is where I started with it until I realised we need this fix. |
# Conflicts: # src/services/Conditions.php
Highly doubt anyone is referencing those properties; it should be safe to fully remove. |
@brandonkelly works for me! Updates pushed. |
Description
Currently, the entry type condition will only allow the ability to define one entry type for its value.
This PR adjusts the functionality so that the
TypeConditionRule
becomes multi selectable allow the ability to specifyin
/not in
a list of entry types. This gives a little more power to the rule.