Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard a11y updates #11217

Merged
merged 8 commits into from
Jun 8, 2022
Merged

Dashboard a11y updates #11217

merged 8 commits into from
Jun 8, 2022

Conversation

gcamacho079
Copy link
Contributor

@gcamacho079 gcamacho079 commented May 12, 2022

Description

  • Sets aria-label on Check Again button on Dashboard to prevent mismatch between visual and accessible name (Resolves DEV-293)
  • Make widget settings button accessible to keyboard users (Resolves DEV-274)
  • Slightly darken text inside draft entry badges (Resolves DEV-661)

@gcamacho079 gcamacho079 requested review from nfourtythree and a team as code owners May 12, 2022 22:19
@linear
Copy link

linear bot commented May 12, 2022

DEV-293 Set aria-label on "Check again" button on Dashboard

Currently includes icon font text

DEV-274 Update widget settings "button" to be accessible via keyboard

Dashboard widget settings buttons are not accessible via keyboard. Use a button, or link with button role and ARIA expanded/collapsed and controls attributes.

@gcamacho079 gcamacho079 requested a review from brandonkelly May 12, 2022 22:20
@gcamacho079 gcamacho079 added the accessibility 👤 features related to accessibility label May 24, 2022
@linear
Copy link

linear bot commented Jun 1, 2022

DEV-661 Draft badge on Dashboard recent entries doesn't meet contrast requirements

Page Area:

Issue Description:

Action:

Screenshot/Code Snippet:

Resolves CMS-232

Screen Shot 2022-05-23 at 2.31.05 PM.png

# Conflicts:
#	src/web/assets/cp/dist/css/cp.css
#	src/web/assets/cp/dist/css/cp.css.map
@brandonkelly brandonkelly merged commit fadbc1f into 4.1 Jun 8, 2022
@brandonkelly brandonkelly deleted the a11y/dashboard-updates branch June 8, 2022 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility 👤 features related to accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants