-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More quick a11y updates #11563
More quick a11y updates #11563
Conversation
DEV-479 Action buttons overflow document width and cause horizontal scrolling at 320px viewport width
Where: Element edit screen - action button row Action buttons cause a horizontal overflow at small screen sizes The content should reflow onto different rows to prevent horizontal scrolling of the viewport at small screen sizes
Screen Shot 2022-04-13 at 10.18.09.png Resolves CMS-130 DEV-465 Revision menu does not have a programmatically-determined label
This menu element does not have an associated label. Screen Shot 2022-04-11 at 8.26.57 AM.png Update the component to use a disclosure menu, with the text "Revision history". A separate text node should be added outside of the menu that shows what version is selected. Resolves CMS-124 DEV-314 Button for entry version history doesn't adequately describe purpose
Should read 'Version History', 'Revision History' or something of the like DEV-496 "Download" button contains CSS icon content that should be marked as decorative
Where: Assets action buttons The button text reads as "Download download" Either the CSS element should be marked as presentational so its content is not read, or an aria-label should be set on the button itself DEV-482 The disabled state of the "Select" button in element selector modal isn't marked as disabled for screen reader users
Where: Element selector modal (.elementselectormodal) When an element has not been selected, the button is visually disabled and does not respond to the click event. However, it isn't marked as such in the HTML The button should be given an attribute of
DEV-453 Draft icon in element sidebar metadata is not hidden from screen reader users
Location: Draft category/entry metadata When reading through elements in the sidebar using a screen reader, the decorative "draft" icon is still being read The decorative "draft" font icon should be hidden from screen reader users using aria-hidden Resolves CMS-118 DEV-400 Copy to Clipboard modal is unusable at 320px screen size
Content does not reflow at 320px screen width, making copy to clipboard modal unusable (button cannot be reached) Use reflow techniques to prevent content clipping at 320px wide screen sizes Resolves CMS-085 DEV-375 When "search in subfolders" input is active then hidden, keyboard can still focus on it
Keyboard focuses on invisible content after the checkbox is hidden Instead of using opacity: 0 on the input wrapper, either:
DEV-337 Language and Formatting Locale select overflows page at 320px
Entire select dropdown overflows the main page container, causing information to be clipped Select dropdown should not overflow the page container, or cause an overflow scroll in a horizontal direction at any screen size Screen Shot 2022-03-17 at 1.10.25 PM.png Resolves CMS-050 DEV-173 Update "Add new category" button in Settings > Categories
Currently reads "plus add new category" |
# Conflicts: # src/web/assets/admintable/dist/css/app.css # src/web/assets/admintable/dist/js/app.js # src/web/assets/admintable/dist/js/app.js.map # src/web/assets/admintable/dist/manifest.json # src/web/assets/cp/dist/cp.js # src/web/assets/cp/dist/cp.js.map # src/web/assets/cp/dist/css/cp.css # src/web/assets/cp/dist/css/cp.css.map # src/web/assets/pluginstore/dist/css/app.css # src/web/assets/pluginstore/dist/css/app.css.map
…ink when value was deleted
Description