Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally show require * for address fields based on validation rules #11566

Merged
merged 4 commits into from
Jul 7, 2022

Conversation

nfourtythree
Copy link
Contributor

Description

Now that the validation for addresses is all part of the rules we can try and help the content editor by showing the * only when the field is actually required.

This helps when a developer may have changed the default validation rules using the define rules event.

@nfourtythree nfourtythree requested a review from brandonkelly July 7, 2022 08:11
@nfourtythree nfourtythree self-assigned this Jul 7, 2022
@nfourtythree nfourtythree requested a review from a team as a code owner July 7, 2022 08:11
@brandonkelly
Copy link
Member

We should not be factoring in the scenario, as it’s helpful to know which fields are required regardless of whether they will actually be validated on save.

@brandonkelly brandonkelly reopened this Jul 7, 2022
@brandonkelly brandonkelly merged commit 8b5ae59 into develop Jul 7, 2022
@brandonkelly brandonkelly deleted the feature/address-fields-form-required branch July 7, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants