-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update slideout to use mobile styles under 600px viewport width #11636
Conversation
DEV-701 Add an address slideout becomes difficult to use at 320px wide
Page Area: Address tab - address slideout Issue Description: On small/zoomed screens, the form takes up less than half of the viewport width, making the form difficult to use Action: Ensure that the form is wider on smaller screens or with higher zoom levels Screenshot/Code Snippet: Screen Shot 2022-06-07 at 13.11.34.png Resolves CMS-241 DEV-480 On 320px screens, slug field in element slideout can no longer be seen or edited
Where: Element edit slideout The slug field value goes to 0px width on small/zoomed screens The CSS dynamically calculates this width to be 100% minus a set px value, which ends up falling below zero at this screen size. The CSS should be modified to account for smaller screen sizes
Resolves CMS-131 |
# Conflicts: # src/web/assets/admintable/dist/css/app.css # src/web/assets/admintable/dist/js/app.js # src/web/assets/admintable/dist/js/app.js.map # src/web/assets/cp/dist/cp.js # src/web/assets/cp/dist/cp.js.map # src/web/assets/pluginstore/dist/css/app.css.map
@gcamacho079 Is there a reason you went with 600px for this? I was thinking it would be good to move Looking through the CSS media queries, looks like the smallest viewport size we check for currently is 500px, when determining whether 25/50%-width fields can be displayed side-by-side: cms/src/web/assets/cp/src/css/_cp.scss Lines 1585 to 1591 in 1c7f4ee
Do you think we should change that media query to start at 600px, or drop the |
@brandonkelly My rationale here was that at 500px wide, the slideout is only about 250px wide. When I was testing in responsive design mode, 300px seemed like a comfortable minimum width for it. We could always have the |
# Conflicts: # src/web/assets/cp/dist/cp.js # src/web/assets/cp/dist/cp.js.map
[ci skip]
👍🏻 Went with 600px. |
Description
Resolves DEV-701, DEV-480
Related issues