A11y/4.3 quick fixes #11767
Merged
A11y/4.3 quick fixes #11767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns and edition logo in footer
…tyles, darken global placeholder text
…older to darker color
gcamacho079
requested review from
benjamindavid,
nfourtythree and
a team
as code owners
DEV-952 "View site" link in navigation doesn't match visible text
Page Area: #system-info Issue Description: The visible name is the site name, but the ARIA label reads "View site" Action: Unset ARIA label from the link Screenshot/Code Snippet: Resolves CMS-252 DEV-325 Default "Formatting Locale" selection doesn't meet minimum contrast ratio
Contrast of "Same as language" text is only 2.51:1. Text color should be darkened to match the color of a selected option. My Account - Preferences Resolves CMS-044 |
# Conflicts: # src/templates/_layouts/components/global-sidebar.twig # src/web/assets/admintable/dist/css/app.css # src/web/assets/admintable/dist/js/app.js # src/web/assets/admintable/dist/js/app.js.map # src/web/assets/cp/dist/css/cp.css # src/web/assets/cp/dist/css/cp.css.map # src/web/assets/craftsupport/dist/css/CraftSupportWidget.css.map # src/web/assets/dashboard/dist/css/Dashboard.css.map # src/web/assets/edittransform/dist/css/transforms.css.map # src/web/assets/edituser/dist/css/AccountSettingsForm.css.map # src/web/assets/edituser/dist/css/profile.css.map # src/web/assets/generalsettings/dist/css/rebrand.css.map # src/web/assets/graphiql/dist/css/graphiql.css.map # src/web/assets/installer/dist/css/install.css.map # src/web/assets/login/dist/css/login.css.map # src/web/assets/money/dist/css/Money.css.map # src/web/assets/plugins/dist/css/PluginManager.css.map # src/web/assets/pluginstore/dist/css/app.css # src/web/assets/pluginstore/dist/css/app.css.map # src/web/assets/pluginstoreoauth/dist/css/PluginStoreOauthCallback.css.map # src/web/assets/routes/dist/css/routes.css.map # src/web/assets/systemmessages/dist/css/system_messages.css.map # src/web/assets/updater/dist/css/Updater.css.map # src/web/assets/updates/dist/css/UpdatesUtility.css.map # src/web/assets/upgrade/dist/css/UpgradeUtility.css.map # src/web/assets/userpermissions/dist/css/UserPermissions.css.map # src/web/assets/utilities/dist/css/utilities.css.map
[ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues