Sticky content footer + move element actions into it #11844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonkelly
added
accessibility 👤
DEV-376 Action and Set Status buttons appear before table instead of after it, making it difficult for screen reader users to discover
Because these buttons appear earlier in the tab order, it's possible for a SR user to never know that these elements have appeared. It's also not ideal to have a keyboard user have to tab backwards to reach these buttons Move these buttons into the table footer area, such as near the export button |
# Conflicts: # src/web/assets/cp/dist/cp.js # src/web/assets/cp/dist/cp.js.map # src/web/assets/cp/dist/css/cp.css # src/web/assets/cp/dist/css/cp.css.map
brandonkelly
force-pushed
the
feature/dev-376-action-and-set-status-buttons-appear
branch
from
9867703 to
104ce22
Compare
|
@brandonkelly looks great! I completed a manual audit on this and no new issues are introduced. I made a small update to resolve a missing label issues (since the Garnish update to custom selects, the buttons aren't inheriting accessible names from their inner text). Resolves DEV-992 |
…https://github.com/craftcms/cms into feature/dev-376-action-and-set-status-buttons-appear
[ci skip]
brandonkelly
deleted the
feature/dev-376-action-and-set-status-buttons-appear
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Element action triggers are now inserted in the content footer, beside the “Export” button, rather than in the toolbar (where they previously replaced all other toolbar items).
The footer is also sticky now, to the bottom of the window, so it is always in view.
Related issues