Status icon updates #11911
Merged
Status icon updates #11911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcamacho079
requested review from
benjamindavid,
nfourtythree and
a team
as code owners
# Conflicts: # src/web/assets/cp/dist/css/cp.css # src/web/assets/cp/dist/css/cp.css.map
|
Not sure how I feel about that “All” icon – it looks like a radio button now, or maybe the image focal point indicator, neither of which really convey “all inclusive” to me. Would this gradient BG work?
When “Use shapes to represent statuses” is enabled, we could use a diamond:
|
@brandonkelly Way better 👍🏼 That would certainly do the trick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue 6916 mentioned the confusing UX surrounding the "All" and "Disabled" status icons being identical; in addition, icons in Lightswitch custom field columns for "Enabled"/"Not Enabled" were identical to "Live"/"Disabled"
This PR adds new styles to the "All" icon, and updates the presentation of values for Lightswitch fields to use checkboxes instead.
Related issues