Manage focus for HUD components #11985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o $hud after trigger tab press
… focusable elements and implement inside WIP for HUD menu
…ast keyboard focusable element in HUD
gcamacho079
requested review from
benjamindavid,
nfourtythree and
a team
as code owners
DEV-405 HUD menus are not in a logical focus order for keyboard interaction
Because HUD menus are moved to the end of the DOM and focus isn't managed in a way that moves keyboard focus into them when they are opened, keyboard users must tab through the rest of the DOM to reach their contents. Also, when a user tabs out of them, they are at the end of the document instead of tabbing into the element next to the trigger button. To solve:
This affects the:
|
…l-focus # Conflicts: # src/web/assets/garnish/dist/garnish.js # src/web/assets/garnish/dist/garnish.js.map # src/web/assets/pluginstore/dist/css/app.css [ci skip]
[ci skip]
brandonkelly
deleted the
feature/dev-405-hud-menus-are-not-in-a-logical-focus
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements focus management for HUD menus.
Adds a couple new functions to Garnish for getting keyboard-focusable elements, versus elements that are programmatically-focusable. In the widget settings HUD, there's an
objectelement withtabindex="-1"that gets returned with the:focusableselector, but doesn't receive keyboard focus. These functions help bypass the issue when tabbing from the last element in the HUD and the next element in the focus order after the trigger.Related issues