Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dev 1043 viewable asset and entry condition rules #12266

Merged

Conversation

brandonkelly
Copy link
Member

Description

  • Adds new savable params to asset and entry queries
  • “Editable” asset/entry condition rules have been renamed to “Savable”(*), and their modifyQuery() methods now use the new savable params
  • Adds “Viewable” asset/entry condition rules, which call asset/entry queries’ editable params

(*) This resolves an awkward inconsistency regarding the meaning of “editable”. It generally means “viewable” in the code (getEditableSections(), editable element query params, etc.), however it meant “savable” in the “Editable” condition rules added in 4.3. Now we just avoid the word altogether and say what we really mean in the condition rules: “Savable” and “Viewable”.

Related issues

@brandonkelly brandonkelly requested a review from a team as a code owner November 6, 2022 02:34
@linear
Copy link

linear bot commented Nov 6, 2022

@brandonkelly brandonkelly merged commit 329b121 into 4.4 Nov 6, 2022
@brandonkelly brandonkelly deleted the feature/dev-1043-viewable-asset-and-entry-condition-rules branch November 6, 2022 18:06
brandonkelly added a commit that referenced this pull request Nov 6, 2022
This was referenced Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant