Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css adjustments for entries filter with v-long field names #12320

Merged
merged 4 commits into from
Nov 16, 2022

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Nov 16, 2022

Description

"Entries filter not working with long field names".
If field names are very long, the filter menu goes off the screen and you have to zoom out to fully see it and be able to interact. This change:

  • checks if the _menuWidth is bigger than the space we have to fit it in (left and right aligned respectively) and sets a max-width if otherwise menu would be too big to fit in
  • updates conditional of when to _alignRight so that we don't align right if the menu is bigger than the space we have to the right
  • updates css so that the very long field names in conditionRules is able to wrap text and expand

Example of a very long field name: "AA This is my very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very long field name1"

Screenshot 2022-11-16 at 08 44 22
Screenshot 2022-11-16 at 08 44 41

Related issues

#12311

@i-just i-just requested a review from a team as a code owner November 16, 2022 09:31
@brandonkelly brandonkelly self-requested a review as a code owner November 16, 2022 12:43
@brandonkelly brandonkelly merged commit 18393d2 into develop Nov 16, 2022
@brandonkelly brandonkelly deleted the bugfix/12311-entries-filter-long-field-names branch November 16, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants