Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make adjustments to announcements button and HUD #12361

Merged
merged 7 commits into from
Nov 29, 2022
Merged

Conversation

gcamacho079
Copy link
Contributor

@gcamacho079 gcamacho079 commented Nov 22, 2022

Description

Makes some small fixes for the announcement button and HUD, including:

  • Adding a visually-hidden text alternative for the unread message dot
  • Adjusting button color for active state
  • Changing DOM order so that the announcement label comes after the heading
  • Changing heading levels so announcement headings are nested under a parent heading

Related issues

Resolves DEV-1049, DEV-1050, DEV-1051, DEV-1052, DEV-1053

@gcamacho079 gcamacho079 requested a review from a team as a code owner November 22, 2022 23:32
@linear
Copy link

linear bot commented Nov 22, 2022

DEV-1049 Announcement list is not marked up as a list

Page Area:

#announcements

Issue Description:

Announcements are not contained in a list element

Action:

Use a semantic list

Screenshot/Code Snippet:

N/A

Resolves CMS-279

DEV-1050 Announcement icon is decorative, but not hidden from assistive technologies

Page Area:

.announcement-icon

Issue Description:

The announcement icon should be hidden from AT

Action:

Use aria-hidden

Screenshot/Code Snippet:

N/A

Resolves CMS-280

DEV-1051 Announcement heading structure can be improved

Page Area:

.announcement h2

Issue Description:

Announcement titles use H2 elements, but would be more easily parsed using a visually-hidden H2 titled "Announcements" with announcement titles using H3 elements

Action:

See above

Screenshot/Code Snippet:

N/A

Resolves CMS-281

DEV-1052 Announcement "vendor" comes after heading in DOM order

Page Area:

.announcement h2

Issue Description:

The vendor (i.e. Craft CMS) comes before the name of the announcement in the DOM order, meaning a user might not know the source of the announcement unless they navitgate backwards in the DOM

Action:

Reverse order for assistive tech

Screenshot/Code Snippet:

N/A

Resolves CMS-285

DEV-1053 When activating the announcement button, the icon contrast falls below the minimum contrast ratio

Page Area:

#announcements-btn

Issue Description:

The active state of the button produces a blue icon, which is only 2.9:1 against the background

Action:

Darken active-state SVG color

Screenshot/Code Snippet:

N/A

Resolves CMS-284

@gcamacho079 gcamacho079 added the accessibility 👤 features related to accessibility label Nov 23, 2022
# Conflicts:
#	src/web/assets/cp/dist/cp.js
#	src/web/assets/cp/dist/cp.js.map
@brandonkelly brandonkelly merged commit d2abc5f into 4.4 Nov 29, 2022
@brandonkelly brandonkelly deleted the a11y/tiny-tweaks branch November 29, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility 👤 features related to accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants