Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1078 asset indexing improvements #12604

Merged
merged 12 commits into from
Feb 3, 2023

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Feb 1, 2023

Description

Previously, when all files and folders were removed from the FS root folder, asset indexing was bailing before it started. This PR changes this behaviour, so indexing will still go ahead even if the FS root folder is completely empty.

It also introduces the listEmptyFolders option, which, if turned on, will list folders that exist but are empty or could be empty because all files in them are listed as missing and allows you to choose to delete such folders.

The review screen now divides into two lists (folders and files) to clarify the messaging in cases where listEmptyFolders is true.

Screenshot 2023-02-01 at 12 09 27

Screenshot 2023-02-01 at 12 10 09

Related issues

#12585

@i-just i-just marked this pull request as ready for review February 2, 2023 09:25
@i-just i-just requested a review from a team as a code owner February 2, 2023 09:25
@brandonkelly
Copy link
Member

Damn @i-just, this is great!

@brandonkelly brandonkelly merged commit ee30858 into 4.4 Feb 3, 2023
@brandonkelly brandonkelly deleted the feature/1078-asset-indexing-improvements branch February 3, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants