Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in which a type error which is thrown if a multi select condition rule is added without any values, as reported in putyourlightson/craft-campaign#367. This is caused by
OptionsFieldConditionRule::elementQueryParam
having a strict return type ofarray
, whereas theparamValue
method has a nullable return type of?array
.cms/src/fields/conditions/OptionsFieldConditionRule.php
Lines 38 to 41 in 3a5ca05
The error encountered is as follows.