Get correct cache key with plugin- prefix #13023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/services/Plugins.php
timkelty
force-pushed
the
fix-purchase-showing-as-trial
branch
from
41819db to
f8d84de
Compare
|
@brandonkelly confirmed this was happening in 3.x as well, so rebased to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were retrieving items from the
licenseInfocache by plugin handle, but they were stored with aplugin-prefix.This seems to fix #12986, but I'm not 💯 sure it is in the right place, as @brandonkelly did the recent updates to licensing info.
Related issues
#12986