Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont assume url #13223

Merged
merged 3 commits into from
May 26, 2023
Merged

Dont assume url #13223

merged 3 commits into from
May 26, 2023

Conversation

timkelty
Copy link
Contributor

@timkelty timkelty commented May 19, 2023

The rename action assumes that an asset will have a URL, which it might not.
This causes a JS error when trying to rename an asset without URLs.

Instead of extracting the filename from the URL, this PR sets filename data and uses that.

Related:

  • cms/src/elements/Asset.php

    Lines 1943 to 1946 in 2c5291f

    // todo: uncomment for v5. Currently Imager X is relying on a relative URL being returned
    //if (!$volume->getFs()->hasUrls) {
    // return null;
    //}

@timkelty timkelty requested a review from a team as a code owner May 19, 2023 05:11
@brandonkelly brandonkelly self-requested a review as a code owner May 26, 2023 21:58
@brandonkelly brandonkelly merged commit de601d8 into develop May 26, 2023
@brandonkelly brandonkelly deleted the dont-assume-url branch May 26, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants