Feature/1129 fs url fields part of fs settings #13224
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
$showHasUrlSetting
and$showUrlSetting
properties were introduced in theFsTrait
. They’retrue
by default, so if FS doesn’t implement any changes, it will work as before.$showHasUrlSetting = false
, which will stop the toggle from showing in the template.showUrlSetting = false
, which will stop the “Base URL” field from showing in the template, even if the “Files in this filesystem have public URLs” is on.hasUrls
andurl
are on the top level)It’s all done as a non-breaking change and could be tidied up for Craft 5. For example, in Craft 5,
$hasUrls
and$url
could be moved to fully be a part of thesettings
.@timkelty At the moment, if the “Files in this filesystem have public URLs” toggle doesn’t show, the “Base URL” field also doesn’t show - LMK if you need this decoupled.
Related issues
dev-1129