Fix BaseDateRangeConditionRule not handling negative intervals correctly. #13463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also noticed some other tests failing when addressing this, like "MoneyTest" and "LanguageValidatorTest". I honestly didn't dig too deep into them. Maybe it's php 8.2 specific or I was missing something that testsuite needed. |
myleshyson
changed the title
|
Thank you!
Those are passing for me locally with this PR, so maybe a fluke. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a bug in the
DateTimeHelper::toDateIntervalmethod, where if passed a negative value, returns a positive interval. This caused an issue inDateRange::dateIntervalByTimePeriod, and subsequently theBaseDateRangeConditionRule.I noticed this when trying to filter elements on the element index page by date period (e.g. After 1 day ago).
I went ahead and added a check for negative numbers in
DateTimeHelper::toDateIntervaland updated theDateTimeHelperTestto make sure it works.DateCreatedConditionRuleTestalso passes now thanks to this fix.Ran these tests using PHP version 8.2.4.