-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fancy crumbs and element action menus #13902
Merged
brandonkelly
merged 68 commits into
5.0
from
feature/cms-1213-fancy-crumbs-action-menus
Nov 19, 2023
Merged
Fancy crumbs and element action menus #13902
brandonkelly
merged 68 commits into
5.0
from
feature/cms-1213-fancy-crumbs-action-menus
Nov 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bar-menu # Conflicts: # src/controllers/ElementsController.php # src/web/assets/cp/dist/cp.js # src/web/assets/cp/dist/cp.js.map # src/web/assets/cp/dist/css/cp.css # src/web/assets/cp/dist/css/cp.css.map # src/web/assets/garnish/dist/garnish.js # src/web/assets/garnish/dist/garnish.js.map
…bar-menu # Conflicts: # src/web/assets/cp/dist/cp.js # src/web/assets/cp/dist/cp.js.map
# Conflicts: # src/controllers/ElementsController.php # src/templates/_includes/revisionmenu.twig # src/web/assets/cp/dist/cp.js # src/web/assets/cp/dist/cp.js.map
Allows for a consistent label on the disclosure menu button.
ACC-7 Convert context menus to disclosure-type menus
IMPORTANT: This should only happen on the element pages, not on index pages/tables. This is because they cause a change of context instead of just loading new page content. However, this could also be accomplished by breaking this out into two separate select components and adding a "Go" button. Accessibility Requirements:
|
…-a11y Fancy Crumbs a11y
[ci skip]
# Conflicts: # src/web/assets/garnish/dist/garnish.js # src/web/assets/garnish/dist/garnish.js.map
This is beautiful, wanted this for years! |
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High level: this redesigns control panel breadcrumbs, and unifies element action menus across edit pages, slideouts, and selectable element chips & cards.
Overview
Technical Details
CpScreenResponseBehavior::site()
, and can make it a menu with additional selectable sites viaCpScreenResponseBehavior::selectableSites()
.CpScreenResponseBehavior::actionMenuItems()
.CpScreenResponseBehavior::contextMenuItems()
.contextMenuHtml()
andcontextMenuTemplate()
have been removed in favor of that.safeActionMenuItems()
anddestructiveActionMenuItems()
.Element::EVENT_DEFINE_ACTION_MENU_ITEMS
.crumbs()
(rather thanprepareEditScreen()
).menu
key, set to an array of menu options.craft\helpers\Cp::disclosureMenu()
.Related