-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable browser autocomplete on user's own address fields #13938
Enable browser autocomplete on user's own address fields #13938
Conversation
…ribute on address field inputs if is own address
CLD-121 Payment method address fields don't use appropriate autocomplete values
Page Area: Billing - payment method modal Issue Description: Address inputs use user information, but don't use autocomplete values that would assist in user input. This includes:
Action: Use autocomplete values specified in Input Purposes for User Interface Components Screenshot/Code Snippet: N/A
|
Feels a little sketchy to be relying on that method on front ends. Couldn’t the Console UI be setting its own |
I’ll need to refresh myself on why I went this route and see if that alternative makes more sense. Will get back to you on this shortly! |
@brandonkelly moved that method to |
I think we should keep Selectize there until we have a better alternative (like the disclosure menu with a search input + inline list, like we talked about). Until then, it does make working with very large selects a lot more manageable. |
Ok! I’ve been working on a mockup/wireframe for this in Figma, trying to think through the a11y UX; I’ll aim to have something concrete by Monday. |
…elds-dont-use-appropriate
…elds-dont-use-appropriate
…appropriate' of https://github.com/craftcms/cms into feature/cld-121-payment-method-address-fields-dont-use-appropriate # Conflicts: # src/templates/_includes/forms/selectize.twig
[ci skip]
Description
Enable autocomplete for most address fields for user’s own address (not other user addresses), the exception being selectize fields. (@brandonkelly would this be a good opportunity to un-selectize locale/address fields entirely, or save that for a later release?)
This PR — specifically the
getInputPurpose
method — will also help achieve WCAG 2.1 AA compliance in Console, as we can use it to set input purposes on the billing address fields.Related issues
Resolves ACC-42