Defer instantiation for memoizable array items (Craft 4) #14104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the complexity from 81f6766 into MemoizableArray, so other things can take advantage of lazy instantiation
Memoize all field layouts, and defer their instantiation
brandonkelly
changed the title
[ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new
$normalizerargument tocraft\base\MemoizableArray’s constructor, which can be used to lazy-instantiate any items within it, once they’re actually requested byall()orfirstWhere().We’re now taking advantage of this everywhere we can, as an initial measure to reducing the number of things that need to get instantiated in any given request.
Related issues