Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color-coded entry types #14187

Merged
merged 4 commits into from
Jan 25, 2024
Merged

Conversation

brandonkelly
Copy link
Member

@brandonkelly brandonkelly commented Jan 24, 2024

Adds a “Color” setting to entry types.

When an entry type has a color selected, entries of that type will be filled in with that color within cards, chips, and inline-editable Matrix blocks.

Matrix fields set to the “inline-editable blocks” view mode have also been redesigned a bit:

  • The titlebar now includes the entry type icon, if it has one
  • Matrix blocks with only one entry type no longer show the entry type icon/label in their titlebars.
  • Block bodies now have a white background color, to improve the visibility of nested chips/cards/Matrix blocks.
  • The “Add” button is now always displayed as a menu, unless there’s only one block type. No more button group listing all types. (This way it’s always consistent regardless of viewport size, and so we can show the block type icons, which would have looked awkward in button group form.)
An entry type’s settings, including the new Color setting A Matrix field’s Entry Types setting, showing several selected color-coded entry types A Matrix field set to the inline blocks view mode, where the blocks are each color-coded A Matrix field set to the cards view mode, where the blocks are each color-coded An expanded Entry Type menu, listing entry type options with color-coded icons

Copy link

linear bot commented Jan 24, 2024

@brandonkelly brandonkelly merged commit 201d524 into 5.0 Jan 25, 2024
6 checks passed
@brandonkelly brandonkelly deleted the feature/cms-1242-color-coded-entry-types branch January 25, 2024 04:01
brandonkelly added a commit that referenced this pull request Jan 25, 2024
@davidhellmann
Copy link
Contributor

Like the stuff! Question, can we bring in the color and the Icon here (entry type overview) too:
image

Would be great.

@brandonkelly
Copy link
Member Author

brandonkelly commented Feb 1, 2024

@davidhellmann Added for the next release! (e40778a)

An entry type index, showing colored icons beside each entry type’s name

@brandonkelly
Copy link
Member Author

5.0.0-alpha.11 is now tagged with that change.

@alexanderloewe
Copy link

Cool, an exciting update.

However, I noticed that the spacing of the icons seems a bit disharmonious. To illustrate this, I've created a brief visualization.

Bildschirmfoto 2024-02-02 um 00 51 56

@brandonkelly
Copy link
Member Author

@alexanderloewe are you just basing that on the screenshot I posted? I shrunk them down a bit to match global nav icon size in 996e73d.

@alexanderloewe
Copy link

alexanderloewe commented Feb 2, 2024

Yes, I actually did base it on your screenshot. Sometimes I take things a bit too literally – I thought that was already the final version! But no worries, in the actual design context, everything looks great. Fits like Cinderella's shoes.

Bildschirmfoto 2024-02-02 um 02 18 43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants